Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript typings #12

Closed
kirillgroshkov opened this issue Sep 5, 2018 · 3 comments
Closed

TypeScript typings #12

kirillgroshkov opened this issue Sep 5, 2018 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@kirillgroshkov
Copy link
Contributor

Sindre, what's your current position on bundling Typescript typings to the repository? Somewhere I got the impression that you like Typescript and find typings useful. Do you intend to add them yourself? Will you allow someone to help with them? (but what about maintenance if you will change the API?)

Will you accept PR with initial typings?
@sindresorhus sindresorhus changed the title Typescript typings TypeScript typings Sep 5, 2018
@sindresorhus
Copy link
Owner

A pull request is more than welcome. Just follow the style guide: https://github.com/sindresorhus/typescript-definition-style-guide :)

@sindresorhus sindresorhus added enhancement New feature or request help wanted Extra attention is needed labels Sep 5, 2018
Repository owner deleted a comment from winterfall1121 Sep 6, 2018
@kirillgroshkov
Copy link
Contributor Author

PR: #20 (review)

@rick-you rick-you mentioned this issue Sep 11, 2018
Merged
@kirillgroshkov
Copy link
Contributor Author

great! Having typings in place I'll go ahead and try it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sindresorhus @kirillgroshkov