Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser file is emitted on Webpack and Babel umd library build #471

Closed
nugaon opened this issue Nov 27, 2022 · 1 comment
Closed

browser file is emitted on Webpack and Babel umd library build #471

nugaon opened this issue Nov 27, 2022 · 1 comment

Comments

@nugaon
Copy link

nugaon commented Nov 27, 2022

Summary

Using Webpack and Babel umd build, the library produces browser file for both browser and node environment.
Even stranger is that it emits this file multiple times at node build that also causes error for the process.

You can reproduce it by cloning this repo and running npm i.

Origin story

One of our dependencies had to update this library because of the missing duplex member in the request.
The library also became ESM that we tried to import into our library after which it did not work with Jest tests.
Now, there are attempts to build this dependency with our stack that you can see above in order to have Jest tests.

@sindresorhus
Copy link
Owner

You should ask this question in the Webpack issue tracker instead. This is about Webpack, not Ky. We are just using the standard package.json exports config.

@sindresorhus sindresorhus closed this as not planned Won't fix, can't repro, duplicate, stale Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants