-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't link issues within backquotes #4
Comments
We could support |
Would you achieve that by making it a negative match within https://github.com/sindresorhus/issue-regex though? I'm not sure escaped issues necessarily goes against that repository's goals. |
We can do it in |
I think this module should be run on clean strings only. The string you're mentioning is a markdown string, so you should probably be using a markdown parser instead of this module (or at least parse it yourself before passing it here.) Otherwise, why should it support backticks and not the HTML string |
This can be closed, as Renovate Bot no longer uses this library. FYI it was used against release notes as part of its efforts to identify github backlinks and escape them, so avoid "backlink spam". |
Do you think it's possible to somehow skip issues that are located within backquotes, e.g. not match/linkify
#123
orIssues #123 and #456
? Linkifying those would result in a pretty ugly output or the user, but I wonder if accurately identifying those would require stateful parsing of markdown to achieve.The text was updated successfully, but these errors were encountered: