Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support of non-ASCII urls #23

Open
tuoxiansp opened this issue Feb 17, 2019 · 1 comment
Open

Support of non-ASCII urls #23

tuoxiansp opened this issue Feb 17, 2019 · 1 comment
Labels
enhancement help wanted

Comments

@tuoxiansp
Copy link

Please support CJK urls like: https://语c.com

see https://runkit.com/tuoxiansp/5c68df202420a30012202c06

I also tested url-regex, this supports well:

https://runkit.com/tuoxiansp/5c68de8514a5c10014ac66c2
@sindresorhus
Copy link
Owner

sindresorhus commented Feb 17, 2019 •
edited

Sure. PR welcome. I think you can use the regex u flag and \p{L} (letters) and \p{Nd} (digits). We cannot use the url-regex package as it has some other limitations.

@sindresorhus sindresorhus changed the title support of CJK urls Support of CJK urls Feb 17, 2019
@fregante fregante mentioned this issue Oct 6, 2021
Closed
1 task
@fregante fregante changed the title Support of CJK urls Support of non-ASCII urls Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sindresorhus @tuoxiansp