Skip to content

Commit

Permalink
TypeScript - Fix the cache type (#29)
Browse files Browse the repository at this point in the history
  • Loading branch information
dylang authored and sindresorhus committed Mar 31, 2019
1 parent 6959d90 commit 298a71e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
2 changes: 1 addition & 1 deletion index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export interface Options<
*
* @default new Map()
*/
readonly cache?: CacheStorage<CacheKeyType, ReturnType>;
readonly cache?: CacheStorage<CacheKeyType, {data: ReturnType; maxAge: number}>;

/**
* Cache rejected promises.
Expand Down
7 changes: 5 additions & 2 deletions index.test-d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,13 @@ expectType<(string: string) => boolean>(mem(fn));
expectType<(string: string) => boolean>(mem(fn, {maxAge: 1}));
expectType<(string: string) => boolean>(mem(fn, {cacheKey: (...arguments_) => arguments_}));
expectType<(string: string) => boolean>(
mem(fn, {cacheKey: (...arguments_) => arguments_, cache: new Map<[string], boolean>()})
mem(
fn,
{cacheKey: (...arguments_) => arguments_,
cache: new Map<[string], {data: boolean; maxAge: number}>()})
);
expectType<(string: string) => boolean>(
mem(fn, {cache: new Map<[string], boolean>()})
mem(fn, {cache: new Map<[string], {data: boolean; maxAge: number}>()})
);
expectType<(string: string) => boolean>(mem(fn, {cachePromiseRejection: true}));

Expand Down

0 comments on commit 298a71e

Please sign in to comment.