Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude progressive web apps from being merged #8

Closed
schana opened this issue Nov 6, 2020 · 6 comments
Closed

Exclude progressive web apps from being merged #8

schana opened this issue Nov 6, 2020 · 6 comments

Comments

@schana
Copy link

schana commented Nov 6, 2020

Currently, if a PWA is opened, it is merged into the chrome window. It would be desirable if this was not the case, as it ruins the distinct "app" nature of whatever was merged. For example, YouTube Music or Google Chat.

@sindresorhus
Copy link
Owner

What exactly do you mean by PWA? "More Tools => Create Shortcut"? Can you provide an example? Because this extension already just fetches normal windows, so not sure how it would detect a PWA.

@schana
Copy link
Author

schana commented Dec 20, 2020

Before the merge, YouTube Music is in its own window as a progressive web app:
before merge
After merge, it's converted to a tab in the browser:
after merge

@sindresorhus
Copy link
Owner

I'm happy to accept a pull request to fix this, but it's unclear to me whether this is a bug in Chrome or if not, whether it's even possible to detect this.

@schana
Copy link
Author

schana commented Jan 14, 2021

Looks like the root cause is that the PWAs have a windowType of popup, and I'm not sure of a good way to detect whether it's an app or a popup with the information the extension api gives.

@szhu
Copy link

szhu commented Feb 25, 2021

Turns out the code explicitly looks for tabs belonging to PWAs, so this was surprisingly easy to fix.

#10

@schana
Copy link
Author

schana commented Aug 26, 2022

This is no longer an issue. For YouTube Music at least, the tab now has a windowType of app, so the code works as-is.

@schana schana closed this as completed Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants