Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move-file only supports node >= 10.17 #10

Closed
ro-savage opened this issue May 19, 2020 · 9 comments
Closed

move-file only supports node >= 10.17 #10

ro-savage opened this issue May 19, 2020 · 9 comments

Comments

@ro-savage
Copy link

Hi,

move-file is breaking dependencies upstream because it required node 10.17.
While other packages believe they only need node 10.x

For example:
npm/cacache#37
webpack-contrib/compression-webpack-plugin#165

Does this package really need node 10.17? A quick glance as the code looks like it would work on all 10.x versions of node?

@artembatura
Copy link

artembatura commented May 20, 2020

The same issue, it's breaks my CI tests
UPD: Just choosed another docker image with newever Node version, issue is not relevant for me

@tillcarlos
Copy link

Same issue. It's coming with "@rails/webpacker@5.0.1" (via cacacher), and thus breaks on heroku

Heroku: "Ruby apps now default to Node version 10.15.3 and Yarn version 1.16.0"

@deviantfero
Copy link

This issue is also affecting copy-webpack-plugin

@alexander-akait
Copy link

/cc @sindresorhus I know the package has engine field with node https://github.com/sindresorhus/move-file/blob/master/package.json#L14, but a lot of packages do not use same node version in their package.json, for example - https://github.com/npm/cacache/blob/latest/package.json#L93.

A lot of developers use yarn and here generates an error when the node version is not suitable. npm generates an annoying warning. Other developers have problems with CI.

Are you ready to downgrade node version to 10.13? I can send a PR using util.promisify when node is not supported fs.promise.

@sindresorhus
Copy link
Owner

move-file is breaking dependencies upstream because it required node 10.17.
While other packages believe they only need node 10.x

Ugh. There's no winning this: sindresorhus/meta#8 ...

@sindresorhus
Copy link
Owner

Also see 9153d5b#commitcomment-39613575

@sindresorhus
Copy link
Owner

Are you ready to downgrade node version to 10.13?

Why 10.13?

I can send a PR using util.promisify when node is not supported fs.promise.

Sure

@sokra
Copy link

sokra commented Jun 3, 2020

Why 10.13?

I think that's the first LTS node 10 release

@sindresorhus
Copy link
Owner

Closing as this package now targets Node.js 12, so this is no longer relevant.

https://github.com/sindresorhus/move-file/releases/tag/v3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants