Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"@" character not matching #31

Closed
elmpp opened this issue Mar 14, 2020 · 2 comments
Closed

"@" character not matching #31

elmpp opened this issue Mar 14, 2020 · 2 comments

Comments

@elmpp
Copy link

elmpp commented Mar 14, 2020

I would be expecting to see some matches here:

import multimatch from 'multimatch';

const matches1 = multimatch([
  'monotonous-root',
  '@monotonous/core',
  'monotonous',
  'penrice-scripts',
  'penrice-typescript-aliases'
], ["@monotonous.*"]);

const matches2 = multimatch([
  'monotonous-root',
  '@monotonous/core',
  'monotonous',
  'penrice-scripts',
  'penrice-typescript-aliases'
], [".monotonous.*"]);

Both matches1|2 yield empty results. Directly using minimatch yields a match...

@sindresorhus
Copy link
Owner

The pattern should be a glob pattern, not a regex.

The pattern @monotonous.* should be changed to @monotonous/*.

@elmpp
Copy link
Author

elmpp commented Mar 30, 2020

oooopsie daisy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants