Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize domain names to lowercase #98

Closed
millette opened this issue Sep 22, 2019 · 3 comments · Fixed by #99
Closed

Normalize domain names to lowercase #98

millette opened this issue Sep 22, 2019 · 3 comments · Fixed by #99

Comments

@millette
Copy link
Contributor

Since domain names are case insensitive, I'd like an option to normalize
"SindreSorhus.com"
into
"http://sindresorhus.com"
while keeping the path and query strings intact.

It would make finding duplicate URLs slightly easier.

@sindresorhus
Copy link
Owner

sindresorhus commented Sep 22, 2019

I don’t think there’s any reason for an option for this. Lets make it default behavior and do a major release.

@millette
Copy link
Contributor Author

Even better :-) I can take a stab at a PR if no-one else is.

@millette
Copy link
Contributor Author

See #99 - although it already works as expected. I only added a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants