Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore check for npm name when --no-publish #319

Closed
piuccio opened this issue Jan 8, 2019 · 6 comments · Fixed by #323
Closed

Ignore check for npm name when --no-publish #319

piuccio opened this issue Jan 8, 2019 · 6 comments · Fixed by #323
Labels
bug 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted

Comments

@piuccio
Copy link

piuccio commented Jan 8, 2019

Issuehunt badges

I'm using np for a private package that is not published on npm but on a separate server using the command

np --yolo --no-publish

and recently after updating I started getting these messages

? This scoped repo @private/package hasn't been published. Do you want to publish it publicly? (Y/n)

It freaked me out at first but looking at the code it seems like it's supposed to prevent people from publishing a scoped package publicly on npm, which is fine, but since I'm using --no-publish I don't expect the package to be published anyway.

So either there's something wrong and np is trying to publish even if --no-publish is set or that check should be ignored if we're skipping publishing

yaodingyd earned $20.00 by resolving this issue!

@sindresorhus
Copy link
Owner

Yeah, that task should be skipped when --no-publish is passed.

@IssueHuntBot
Copy link

@issuehuntfest has funded $20.00 to this issue. See it on IssueHunt

Repository owner deleted a comment from IssueHuntBot Jan 12, 2019
Repository owner deleted a comment from IssueHuntBot Jan 12, 2019
@sindresorhus
Copy link
Owner

@yaodingyd You need to submit your PR URL in IssueHunt to get the reward for this.

@IssueHuntBot
Copy link

@yaodingyd has submitted a pull request. See it on IssueHunt

@yaodingyd
Copy link
Contributor

@sindresorhus thanks!

@IssueHuntBot
Copy link

@sindresorhus has rewarded $18.00 to @yaodingyd. See it on IssueHunt

  • 💰 Total deposit: $20.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $2.00

@issuehunt-oss issuehunt-oss bot added the 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt label May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants