Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release draft uses wrong tag #434

Closed
sholladay opened this issue Jun 21, 2019 · 2 comments · Fixed by #435
Closed

Release draft uses wrong tag #434

sholladay opened this issue Jun 21, 2019 · 2 comments · Fixed by #435
Labels

Comments

@sholladay
Copy link
Contributor

Description

The tag that np uses in the release draft template is based on the raw input of the user on the command line, rather than the actual tag being used during the release. This causes the release draft to be broken for users who increment the package version by semver type instead of providing a predetermined version number. For example, running np major instead of np 1.0.0.

Steps to reproduce

  1. Run np major (or any other increment type, such as patch)
  2. See the release draft refers to a vmajor tag, which does not exist

Expected behavior

The release draft must use the resolved tag/version number, as determined by npm, not merely the raw user input.

Environment

np - 5.0.3
Node.js - 12.4.0
npm - 6.9.0
Git - 2.22.0
OS - macOS 10.13.6

@sindresorhus
Copy link
Owner

// @yaodingyd

@yaodingyd
Copy link
Contributor

Confirmed. Working on a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants