Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] create release draft option (e.g. np release-draft <version>) would trigger release page #478

Closed
niftylettuce opened this issue Dec 12, 2019 · 8 comments · Fixed by #578

Comments

@niftylettuce
Copy link

An alternative to release perhaps that matches release consistency.

@sindresorhus
Copy link
Owner

What's the use-case?

@niftylettuce
Copy link
Author

When np fails, like has happened with the past few versions.

#422 and #418

@sindresorhus
Copy link
Owner

I don't think that's a good argument for adding a feature. The problems should be fixed instead. That being said, I'm open to adding this as it could be useful for non-Node.js projects.

@make-github-pseudonymous-again

When np fails, like has happened with the past few versions.

#422 and #418

It can also fail independently of np. It just happened to me that I close the release draft browser tab by accident and cannot open it again. Also happened in the past.

@dopecodez
Copy link
Collaborator

@sindresorhus any ideas on the implementation?
We already have a releaseDraft flag to enable or disable github releases. Reusing this could cause confusions. But adding a flag with a similar name and purpose really doesn't make much sense.
Can we change the releaseDraft to mean if specified to just open the release url, and in case specified to be false to skip the whole process?
Any other ideas on how to implement this?

@make-github-pseudonymous-again

@sindresorhus any ideas on the implementation?
We already have a releaseDraft flag to enable or disable github releases. Reusing this could cause confusions. But adding a flag with a similar name and purpose really doesn't make much sense.
Can we change the releaseDraft to mean if specified to just open the release url, and in case specified to be false to skip the whole process?
Any other ideas on how to implement this?

Seems sensible to skip default behavior if --release-draft is explicited. The same would be true for a hypothetical --yarn flag (I believe it is already the case that if --no-yarn is not present the service used depends on who called np).

@Drarig29
Copy link
Contributor

Drarig29 commented Nov 4, 2020

I confirm this would be very useful to be able to trigger only the release draft.

My connection went down when pushing tags (just before triggering the draft) and I had to Ctrl+C the process. And now I have to manually write a release report...

Maybe you could add something like np --release-draft-only.

Edit: Actually, it wasn't a connection problem. I tested manually to push the tags and it prompted me to enter my git credentials. That was why the "Pushing tags" step was spinning infinitely. This is the same issue as #417.

@fregante
Copy link
Collaborator

fregante commented Nov 7, 2020

I'm open to adding this as it could be useful for non-Node.js projects.

Wouldn't that be an argument for the extraction of this feature into its own package a-la release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants