Add --test-script flag to run custom tests before publish
#557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging forks
dopecodez
changed the title
sindresorhus
changed the title
--test-script flag to run custom tests before publish
sindresorhus
changed the title
--test-script flag to run custom tests before publish--test-script flag to run custom tests before publish
sindresorhus
requested changes
Jul 20, 2020
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
|
Updated |
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
|
Can you fix the conflict? |
|
Fixed the conflict @sindresorhus |
sindresorhus
reviewed
Aug 6, 2020
sindresorhus
reviewed
Aug 8, 2020
|
Thanks for the PR. 👍🏻 It would be great if next time, you could look over the diff a couple of times after doing changes. I feel like I commented on a lot of obvious stuff that could have been caught by you. |
|
I agree @sindresorhus , just got bogged down with work. Will up my PR game for sure. |
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #543 . Updated readme as per the discussion on this issue.