Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create release draft even when pushing to protected branches failed #560

Merged
merged 5 commits into from Aug 29, 2020

Conversation

bunysae
Copy link
Contributor

@bunysae bunysae commented Aug 17, 2020

Fixes #502.

Setup for tests:

  1. setup branch protection fro some playground repository
  2. publish new version with np

The tags should be pushed and the release draft should be created.

source/git-util.js Outdated Show resolved Hide resolved
source/git-util.js Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

Ideally, we should inform the user that they need to manually push the commits.

@sindresorhus sindresorhus changed the title Creating release draft when pushing to protected branches failed Create release draft even when pushing to protected branches failed Aug 29, 2020
@sindresorhus sindresorhus merged commit 3fc1e77 into sindresorhus:master Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create release notes even if pushing the branch failed
2 participants