Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

np is including irrelevant yarn.lock files #662

Closed
tansanDOTeth opened this issue Aug 19, 2022 · 1 comment
Closed

np is including irrelevant yarn.lock files #662

tansanDOTeth opened this issue Aug 19, 2022 · 1 comment
Labels

Comments

@tansanDOTeth
Copy link

Description

I have multiple yarn.lock files in my library: one for the library and one for an example application.
I added the example application directory into .npmignore, but np is still trying to include it.

This is the output even though .npmignore specifically has example/:

The following new files will be published the first time:
- example/yarn.lock
- rollup.config.js
- yarn.lock

Steps to reproduce

  1. Have a yarn.lock file in the root
  2. Have a yarn.lock file in example/
  3. Add example/ to .npmignore
  4. Run np

Expected behavior

I expect it to respect .npmignore file.

Environment

np - 7.6.2
Node.js - v16.13.0
npm - 8.1.4
Git - 2.32.1
OS - macOS 12.5

@fregante
Copy link
Collaborator

fregante commented Feb 3, 2023

np is not packaging your files, it just calls npm publish.

Run npm pack --dry-run to ensure your npmignore is set correctly

@fregante fregante closed this as not planned Won't fix, can't repro, duplicate, stale Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants