Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency electron not found (in got) when used in Next project #16

Closed
lacymorrow opened this issue Feb 4, 2018 · 2 comments
Closed

Comments

@lacymorrow
Copy link

Ran into an interesting issue using this module in a nextjs project.

This dependency was not found:  
* electron in ./node_modules/npm-name/node_modules/got/index.js  
To install it, you can run: npm install --save electron

I don't want to introduce electron to the project obviously, and looking through the source of got, I'm not sure why it's being required.

Any insight into this?

@sindresorhus
Copy link
Owner

The require is behind a conditional, so this is an issue with nextjs.

@lacymorrow
Copy link
Author

Seems to be an issue with Webpack aggressively bundling dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants