onValidate does not work with arrays

[lroal]

import onChange from 'on-change';

const object = [];

let p = onChange(object, change, { pathAsArray: true, onValidate });

function change() {
    console.log('change');
}

function onValidate(path) {
    console.log('path:')
    console.log(path);
    console.log('object')
    console.log(object)
    return false;
}

p.push(1);
console.log('final')
console.log(p);

output:

path:
[]
object
[ 1 ]
final
[ 1 ]

The change seems to be already done when onValidate is called.

[lroal]

Has anyone had the chance to look at the issue ?

[DarrenPaulWright]

By default onChange wraps up the changes in one method call to one change on the item that the method was called, the same applies to onValidate. That is why you see an empty path with the pushed item there. To bypass this and get callbacks for every change within a method call, use the "details" option.

That said, returning false in the onValidate function should have reverted the change. I'll look into it.

[lroal]

Have you had any chance to look at it ? I assume this part of the code is a bit complex.