Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url option is gone, but it's linked in the readme #241

Closed
jcesarmobile opened this issue Apr 6, 2021 · 1 comment
Closed

url option is gone, but it's linked in the readme #241

jcesarmobile opened this issue Apr 6, 2021 · 1 comment

Comments

@jcesarmobile
Copy link

jcesarmobile commented Apr 6, 2021

On the Double-quotes on Windows section https://github.com/sindresorhus/open#double-quotes-on-windows

There is this comment about url option

To make this caveat somewhat less impactful (at least for URLs), check out the url option. Double-quotes will be "preserved" when using it with an URL.

That links to https://github.com/sindresorhus/open#url
But the url option was removed on version 8, so the link is dead

So that part should probably be removed.
But considering it was there to make "this caveat somewhat less impactful", not sure if there is a better alternative now or if the Double quotes on Windows problem is gone on version 8 and the whole section can be removed.

@sindresorhus
Copy link
Owner

I think the whole section could be removed. @tim-stasse Correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants