Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrectly add "^" before "&" in url query strings #44

Closed
JackCai1206 opened this issue Mar 12, 2017 · 0 comments · Fixed by #146
Closed

Incorrectly add "^" before "&" in url query strings #44

JackCai1206 opened this issue Mar 12, 2017 · 0 comments · Fixed by #146

Comments

@JackCai1206
Copy link

I haven't really looked into index.js for this problem, but this doesn't occur on all urls. This only occurs when I have a space in the url I am trying to open.
To reproduce this issue on windows 10, do opn('https://www.google.com/#q=12 3&*', {app: 'Chrome'}) and the url in the browser will be https://www.google.com/#q=12 3^&*, however, if I do opn('https://www.google.com/#q=123&*', {app: 'Chrome'}) the url opened in the browser is not modified.
I noticed there is a regex replacement target.replace(/&/g, '^&') in index.js, but im not sure why it doesn't replace all the &s with ^&

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant