Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EACCESS on Linux - xdg-open does not have execute permission #70

Closed
grinnery opened this issue Sep 4, 2017 · 4 comments
Closed

EACCESS on Linux - xdg-open does not have execute permission #70

grinnery opened this issue Sep 4, 2017 · 4 comments

Comments

@grinnery
Copy link

grinnery commented Sep 4, 2017

Installing the package with npm i opn -S (or directly from git repo) does not preserve executable attribute on xdg-open, resulting in EACCESS when opn-ing URLs.

@sindresorhus
Copy link
Owner

sindresorhus commented Sep 5, 2017

See npm/npm#18324. Keeping this open until that is resolved.

@EvanCarroll
Copy link

EvanCarroll commented Sep 5, 2017

Why are you even shipping your own version of xdg-open. Can't we delegate to /usr/bin/env xdg-open and use the system's version if present? That would also help constrain security probs. I imagine not everyone wants shell scripts installed by npm executing on their system.

@kevva
Copy link

kevva commented Sep 6, 2017

Because not all systems has xdg-open. It's probably easier to track down issues by shipping a local version of it.

@sindresorhus
Copy link
Owner

https://github.com/npm/npm/releases/tag/v5.4.1

This is a very small bug fix release to fix a problem where permissions on installed binaries were being set incorrectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants