Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on windows, can't opn a directory with an ampersand #77

Closed
TanninOne opened this issue Nov 7, 2017 · 9 comments · Fixed by #146
Closed

on windows, can't opn a directory with an ampersand #77

TanninOne opened this issue Nov 7, 2017 · 9 comments · Fixed by #146
Labels
bug 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted

Comments

@TanninOne
Copy link

TanninOne commented Nov 7, 2017

Issuehunt badges

The following line escapes ampersands on windows.
https://github.com/sindresorhus/opn/blob/b9f7e569f5a3d5d520047df3e9f10a42d52fd9d4/index.js#L36

This breaks opening local files and directories where the path contains ampersands.


IssueHunt Summary

herberttn herberttn has been rewarded.

Backers (Total: $30.00)

Submitted pull Requests


Tips


IssueHunt has been backed by the following sponsors. Become a sponsor

@nogueiraantonio
Copy link

I have the same problem.

@dogeared
Copy link

dogeared commented Mar 4, 2019

This also breaks requesting urls with querystrings. The ampersand is the delimeter between querystring parameter.

@IssueHuntBot
Copy link

@IssueHunt has funded $30.00 to this issue.


@stroncium
Copy link

Can anyone provide reproduction steps? I tried both directories and urls and they all worked fine.

@stroncium
Copy link

stroncium commented Mar 28, 2019

@sindresorhus Checked them, but only was able to reproduce it if path contains space. But this issue says it works with all directories with &.

@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label May 10, 2019
@baoti
Copy link

baoti commented Jun 12, 2019

@TanninOne Can you show us your full file path?

@baoti
Copy link

baoti commented Jun 13, 2019

@nogueiraantonio @dogeared Can you show us your full file path or url?
Just like those file paths.

@issuehunt-oss issuehunt-oss bot removed the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label Oct 15, 2019
@issuehunt-oss
Copy link

issuehunt-oss bot commented Oct 15, 2019

@sindresorhus has rewarded $27.00 to @herberttn. See it on IssueHunt

  • 💰 Total deposit: $30.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $3.00

@issuehunt-oss issuehunt-oss bot added the 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt label Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants