New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
on windows, can't opn a directory with an ampersand #77
Comments
I have the same problem. |
This also breaks requesting urls with querystrings. The ampersand is the delimeter between querystring parameter. |
@IssueHunt has funded $30.00 to this issue.
|
Can anyone provide reproduction steps? I tried both directories and urls and they all worked fine. |
@sindresorhus Checked them, but only was able to reproduce it if path contains space. But this issue says it works with all directories with |
@TanninOne Can you show us your full file path? |
@nogueiraantonio @dogeared Can you show us your full file path or url? |
@sindresorhus has rewarded $27.00 to @herberttn. See it on IssueHunt
|
The following line escapes ampersands on windows.
https://github.com/sindresorhus/opn/blob/b9f7e569f5a3d5d520047df3e9f10a42d52fd9d4/index.js#L36
This breaks opening local files and directories where the path contains ampersands.
IssueHunt Summary
herberttn has been rewarded.
Backers (Total: $30.00)
Submitted pull Requests
Tips
IssueHunt has been backed by the following sponsors. Become a sponsor
The text was updated successfully, but these errors were encountered: