Resolves the issues with +x on npm #71
Conversation
Add option **hidden** to hide cmd window in win32.
|
This fixes #70 |
|
|
||
| if (appArgs.length > 0) { | ||
| args = args.concat(appArgs); | ||
| cmd = path.join('/usr', 'bin', 'env'); |
There was a problem hiding this comment.
I'd use something like which here to ensure that we don't use the wrong path.
| if (appArgs.length > 0) { | ||
| args = args.concat(appArgs); | ||
| cmd = path.join('/usr', 'bin', 'env'); | ||
| args.unshift('xdg-open'); |
There was a problem hiding this comment.
Why not cmd = path.join('/usr', 'bin', 'env', 'xdg-open');?
There was a problem hiding this comment.
because xdg-open is the argument to /usr/bin/env there is no app called /usr/bin/env/xdg-open Try running /usr/bin/env xdg-open "http://www.google.com", now try /usr/bin/env/xdg-open "http://www.google.com"
| @@ -47,14 +51,15 @@ module.exports = (target, opts) => { | |||
| args = args.concat(appArgs); | |||
| } | |||
| } else { | |||
| if (appArgs.length > 0) { | |||
| args = args.concat(appArgs); | |||
| } | |||
There was a problem hiding this comment.
Because unshifting (pushing to the front) of an array that isn't yet created is a bad idea. We'd otherwise get clobbered.
|
Thanks, but I rather just wait on npm to fix this. Looks like a fix there is close: zkat/pacote#117 |
|
That's no joy. Shipping out your own copy of |
Works again with linux, resolves the issue with npm disabling -x by sourcing the local
xdg-openthrough/usr/bin/env