Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8 stop but do not release #233

Closed
peterpeterparker opened this issue Dec 23, 2023 · 2 comments
Closed

v8 stop but do not release #233

peterpeterparker opened this issue Dec 23, 2023 · 2 comments

Comments

@peterpeterparker
Copy link

peterpeterparker commented Dec 23, 2023

Hi, I just tried the newest version of ora which I use in my CLI.

While the spinner still works, it seems to not release some process which has for effect to make my CLI commands hang forever.

Example of code:

export const clear = async () => {
  try {
    await doSomething();
  } finally {
    spinner.stop();
  }
};

With v7.0.1:

ok

With v8.0.0:

notok

In the above gif, when it hangs, I try to hit few "Return" on my keyboard and ends the process with Ctrl+C at the end.

@ipec
Copy link

ipec commented Dec 23, 2023

I can confirm this issue with ora version 8.0.0 in my environment. Experiencing similar behavior where the CLI commands hang after executing.

@peterpeterparker
Copy link
Author

I can confirm the fix works out. Thanks a lot, merry Xmas! 🎄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants