Passing cancellation reason to cancel handler

[BendingBender]

Does it make sense to pass the cancellation reason to the registered cancel handlers, like this:

const promise = new PCancelable((resolve, reject, onCancel) => {
    onCancel(reason => {
        console.log(reason); // <= should print 'foo'
    });
});

promise.cancel('foo');

If it does, I'll make a PR.

[sindresorhus]

Do you have any use-case in mind? I don't see why not to add it, but I also don't see what it could be useful for.

[BendingBender]

Not really a use case, I just saw it was a low-hanging fruit. It kind of opens a bi-directional channel between the promise provider and consumer.

[sindresorhus]

// @bfred-it @szmarczak Thoughts?

[fregante]

In 2 years nobody actually needed this, so unless there's real interest maybe it shouldn't be implemented "just in case". Either way, 🤷‍♂️

[szmarczak]

I agree with @bfred-it. I don't see any use case either.