Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thenable isn't cancelable anymore #38

Open
AndyOGo opened this issue Dec 5, 2022 · 2 comments
Open

Thenable isn't cancelable anymore #38

AndyOGo opened this issue Dec 5, 2022 · 2 comments

Comments

@AndyOGo
Copy link

AndyOGo commented Dec 5, 2022

Calling .then() on a CancelablePromise returns a Promise, which can't be canceled anymore.

Problem is here:

p-cancelable/index.js

Lines 73 to 75 in cdec148

then(onFulfilled, onRejected) {
return this.#promise.then(onFulfilled, onRejected);
}

@AndyOGo
Copy link
Author

AndyOGo commented Dec 5, 2022

@idoodler
Copy link

The issue with cancelable-promise is that canceling a promise won't reject it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants