Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recent change for concurrency is breaking change #17

Closed
drewlindsey opened this issue Sep 5, 2019 · 1 comment
Closed

Recent change for concurrency is breaking change #17

drewlindsey opened this issue Sep 5, 2019 · 1 comment

Comments

@drewlindsey
Copy link

Should we up the major version since it no longer can take in a string value for concurrency which may technically be a backwards incompatible change. I know my lib broke from "p-limit": "^2.2.0", which was automatically pulled in on the latest change.
@sindresorhus
Copy link
Owner

It's not a breaking change. concurrency was always documented as being a number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sindresorhus @drewlindsey