Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package breaks IE11 unless built #23

Closed
dcporter opened this issue Feb 19, 2020 · 2 comments
Closed

Package breaks IE11 unless built #23

dcporter opened this issue Feb 19, 2020 · 2 comments

Comments

@dcporter
Copy link

Since IE11 doesn't support arrow functions or rest/spread, the existing package breaks projects that use it in IE11 if they don't build node_modules (a common pattern). This would be resolved if this package were built to target ES5. (Here's another package that ran into this separately.)

@sindresorhus
Copy link
Owner

This module mainly targets Node.js, not the browser. It's up to you to transpile it with Babel if you want to use it in the browser.

If you use Webpack, check out babel-engine-plugin, which transpiles only the dependencies that needs to be transpiled.

If you use Create React App, upgrade to Create React App v2. It supports automatic transpilation of dependencies, which will make this package just work.

@dcporter
Copy link
Author

This module mainly targets Node.js, not the browser.

You have the lightest-weight concurrent queue I'm aware of, the browser is a natural market for this package… ;)

Thanks for the babel-engine-plugin link. The engines field is pretty notoriously misused or forgotten, but I can cross my fingers for no issues…

Having an ES5 build available would solve this perfectly, without special & frankly risky tooling. I understand it's greater-than-zero effort to spin up though. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants