We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add
import PQueue from 'p-queue' const queue = new PQueue(); // has type Promise<string | void> const result = queue.add(() => 'testing');
I would initially expect result to have type of Promise<string>. This commit 8184655 seems to have changed that behavior.
Promise<string>
If I'm reading the types correctly, doing
queue.add(() => 'testing', { throwOnTimeout: true })
should bring back the old typing, but it doesn't.
The text was updated successfully, but these errors were encountered:
// @Richienb
Sorry, something went wrong.
84b32d5
Added type tests
This is still occurring on 7.3.4. See https://github.com/BeeeQueue/dota-matches-api/actions/runs/4212473470/jobs/7311519688
This is still occurring on 7.3.4. See BeeeQueue/dota-matches-api/actions/runs/4212473470/jobs/7311519688
The p-queue API could be improved. For now, pass throwOnTimeout: true as an option.
p-queue
throwOnTimeout: true
No branches or pull requests
I would initially expect result to have type of
Promise<string>
. This commit 8184655 seems to have changed that behavior.If I'm reading the types correctly, doing
should bring back the old typing, but it doesn't.
The text was updated successfully, but these errors were encountered: