Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Flexible Function Arguments for Throttle #30

Closed
jwhenry3 opened this issue Mar 2, 2021 · 1 comment
Closed

More Flexible Function Arguments for Throttle #30

jwhenry3 opened this issue Mar 2, 2021 · 1 comment

Comments

@jwhenry3
Copy link

jwhenry3 commented Mar 2, 2021

throttle(fetch) is having a typescript definition issue right now due to lack of flexibility with the definitions.

On index.d.ts on line 13~14 and 80~81:
Rather than having Argument in the defs, change it to Arguments, and rather than returning ...arguments:Argument[], have it return ...arguments: Arguments. This should resolve its lack of flexibility. I too would be willing to dive in and open a PR if necessary.

@jwhenry3
Copy link
Author

jwhenry3 commented Mar 2, 2021

As of 4.1.1 we are no longer seeing this issue. Please disregard.

@jwhenry3 jwhenry3 closed this as completed Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant