Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HTTP_PROXY / HTTPS_PROXY use with "got" package #22

Closed
pilsy opened this issue Feb 17, 2016 · 3 comments
Closed

Support HTTP_PROXY / HTTPS_PROXY use with "got" package #22

pilsy opened this issue Feb 17, 2016 · 3 comments

Comments

@pilsy
Copy link

pilsy commented Feb 17, 2016

This is so that update-notifier will correctly handle proxies

See https://www.npmjs.com/package/got#proxies for information about using proxies with got

@sindresorhus
Copy link
Owner

Not interested in adding extra stuff for proxy support here. Builtin proxy support is planned for got and you could help out with that instead.

@pilsy
Copy link
Author

pilsy commented Feb 17, 2016

got already supports proxies, and while you "could" make it look at process.env.HTTP_PROXY and process.env.HTTPS_PROXY and then setup an agent for it, i figured that it wasn't the place for it... for instance i may want to use the got package with multiple proxies in a programmatic fashion so why would it lock you into using those variables.

It would be as simple as, passing an agent parameter with your call to got on line 23 of index -- much like CleverStack/cleverstack-cli@5b15523#diff-ad4f0d8fb92260728a1b559aed92cd81R89

@sindresorhus
Copy link
Owner

I'm not going to add custom proxy logic to every single package I have that uses got.

➡️ sindresorhus/got#79 ⬅️

Repository owner locked and limited conversation to collaborators Feb 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants