Added ability to specify cookies

[green-arrow]

Using a .JSON file (see cookies.json), you can attach cookies to the
phantom page request. This will allow you to capture pages that are
behind a login wall.

An issue exists for this at: #41

[sethvoltz]

Very useful for ensuring apps that are only visible post-login still work at common resolutions. +1

[sindresorhus]

Sorry about the delay. Vacation and stuff.

I agree this is needed, but I'm not sure I agree with the implementation.

How about just an option flag:

pageres todomvc.com 1400x000 --cookie 'value1; value2; name1=value1'

where the value is just a normal cookie or multiple.

Thoughts?

[sindresorhus]

// @8bitDesigner

[8bitDesigner]

I like both approaches, however if you do need to specify things like the cookie domain (all our sites share a cookie on *.company.tld, for example), the commandline approach, while cleaner, doesn't seem to allow that.

[sindresorhus]

Yes, it does:

pageres todomvc.com 1400x000 --cookie 'reg_fb_gate=deleted; Expires=Thu, 01-Jan-1970 00:00:01 GMT; Path=/; Domain=.example.com; HttpOnly'

[8bitDesigner]

Oh, I do like that format, then. document.cookie style gets my vote.

[green-arrow]

With this approach, it seems like you'll only be able to specify one domain / path. So if you have 4 cookies, they'll all have the same domain, path, etc. Is that acceptable?

[8bitDesigner]

Could you use, say --cookie "foo=bar;" --cookie "bar=baz" and use multiple --cookie declarations?

[sindresorhus]

Yes

[green-arrow]

That is a pretty rough pass at using the --cookie flag to specify cookies. Unfortunately I don't have a whole lot of time at the moment, so it's not very pretty. I tested quickly with Charles and it looks like it puts the cookies on correctly.

[sindresorhus]

Can you fix the merge conflict? Your fork is out of date ;)

[green-arrow]

Yeah, that was way out of date! Tried to clean up everything, let me know if that fixed it. Have to run at the moment so I won't be able to do any more tonight.

[sindresorhus]

@green-arrow Still interested? Needs a good rebase.

[sindresorhus]

Closing for now as a lot has changed since this PR was opened and lack of activity. Would still welcome a PR that adds cookie support according to #52 (comment).

[sindresorhus]

If anyone is still interested in getting this landed I would happy to receive another PR: #41