Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs #89

Closed
2 tasks done
sindresorhus opened this issue Jun 27, 2014 · 15 comments
Closed
2 tasks done

Improve docs #89

sindresorhus opened this issue Jun 27, 2014 · 15 comments

Comments

@sindresorhus
Copy link
Owner

Feedback welcome on what else.

@jensgro
Copy link

jensgro commented Aug 11, 2014

Hi Sindre,

I would be interested in the documentation of the grunt-task (!) to see how to capture multiple pages with multiple sizes. And if I could capture only fragments of a page, selecting with a css-selector.

@sindresorhus
Copy link
Owner Author

to see how to capture multiple pages with multiple sizes

Done, but it really is just basic grunt config and nothing specifically to do with grunt-pageres though.

sindresorhus/grunt-pageres@4eeeed9

And if I could capture only fragments of a page, selecting with a css-selector.

That's not supported, but I created a ticket for it: #100

@jensgro
Copy link

jensgro commented Aug 11, 2014

That was superfast. Thanks a lot.

@kevva
Copy link
Contributor

kevva commented Aug 18, 2014

@jensgro, fyi, we've added support for capturing DOM elements.

@jensgro
Copy link

jensgro commented Aug 18, 2014

Hi kevva,

I am happy to hear/read that. I updates pageres and tested the new option with grunt-pageres but I have the impression, that this new optiion has to be integrated there, too. I couldn't make screenshots of page-areas. But I am looking forward the integration of this new feature into the grunt-task.

@sindresorhus
Copy link
Owner Author

@jensgro it hasn't been released yet: https://github.com/sindresorhus/pageres/milestones

@boo1ean
Copy link

boo1ean commented Aug 21, 2014

@sindresorhus what about documenting programmatic API? and probably improving a little programmatic API 🌛

@kevva
Copy link
Contributor

kevva commented Aug 21, 2014

@boo1ean
Copy link

boo1ean commented Aug 21, 2014

@kevva guess I've missed it (-‸ლ)
Thanks!

@AllenSH12
Copy link
Contributor

I've expanded on the CLI docs a little here: https://github.com/AllenSH12/pageres#usage

Nothing too drastic but I think it's a step in the right direction. Anyone care to take a look and maybe make some suggestions before I make a PR?

@kevva
Copy link
Contributor

kevva commented Oct 17, 2014

That's too verbose imo. I think using the CLI help output is fine in the readme or else it'll be a long wall of text that nobody reads. But yeah, might link to a tutorial or likewise.

@dt0818
Copy link

dt0818 commented Oct 17, 2014

Default Vogel gbnf

Sent from my iPhone

On Oct 16, 2014, at 23:22, Allen Hernandez notifications@github.com wrote:

I've expanded on the CLI docs a little here: https://github.com/AllenSH12/pageres#usage

Nothing too drastic but I think it's a step in the right direction. Anyone care to take a look and maybe make some suggestions before I make a PR?


Reply to this email directly or view it on GitHub.

@sindresorhus
Copy link
Owner Author

@AllenSH12 I like it. The current clone of the CLI help is there just because I'm lazy. Can you do a PR? Easier to give feedback on a PR.

@kevva I would generally agree, but this tool is used by a lot of CLI beginners eg. designers which could use a bit more handholding, and I've been wanting to make to improve the CLI docs. After this we can probably slim down the usage/examples in the cli help and instead refer here for more docs.

@AllenSH12
Copy link
Contributor

Have submitted the PR here: #131

@kevva
Copy link
Contributor

kevva commented Nov 1, 2014

Fixed in c791708.

@kevva kevva closed this as completed Nov 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants