-
-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve docs #89
Comments
Hi Sindre, I would be interested in the documentation of the grunt-task (!) to see how to capture multiple pages with multiple sizes. And if I could capture only fragments of a page, selecting with a css-selector. |
Done, but it really is just basic grunt config and nothing specifically to do with grunt-pageres though. sindresorhus/grunt-pageres@4eeeed9
That's not supported, but I created a ticket for it: #100 |
That was superfast. Thanks a lot. |
@jensgro, fyi, we've added support for capturing DOM elements. |
Hi kevva, I am happy to hear/read that. I updates pageres and tested the new option with grunt-pageres but I have the impression, that this new optiion has to be integrated there, too. I couldn't make screenshots of page-areas. But I am looking forward the integration of this new feature into the grunt-task. |
@jensgro it hasn't been released yet: https://github.com/sindresorhus/pageres/milestones |
@sindresorhus what about documenting programmatic API? and probably improving a little programmatic API 🌛 |
@kevva guess I've missed it (-‸ლ) |
I've expanded on the CLI docs a little here: https://github.com/AllenSH12/pageres#usage Nothing too drastic but I think it's a step in the right direction. Anyone care to take a look and maybe make some suggestions before I make a PR? |
That's too verbose imo. I think using the CLI help output is fine in the readme or else it'll be a long wall of text that nobody reads. But yeah, might link to a tutorial or likewise. |
Default Vogel gbnf Sent from my iPhone
|
@AllenSH12 I like it. The current clone of the CLI help is there just because I'm lazy. Can you do a PR? Easier to give feedback on a PR. @kevva I would generally agree, but this tool is used by a lot of CLI beginners eg. designers which could use a bit more handholding, and I've been wanting to make to improve the CLI docs. After this we can probably slim down the usage/examples in the cli help and instead refer here for more docs. |
Have submitted the PR here: #131 |
Fixed in c791708. |
--help
dump. Do a tutorial or somethingFeedback welcome on what else.
The text was updated successfully, but these errors were encountered: