New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return ES2015 Proxy object #29
Comments
@schnittstabil Interested in exploring this? I'm requiring Node.js 4 in the next version, so we can safely use Proxy then. |
At least v4.5.0 (LTS) and v5.12.0 don't support Proxies 😢 |
Oh no. I was sure |
@sindresorhus If you'd like to give me access rights, I'll create a proxy-branch and push some v6 code for further usage… |
Done :) |
Yes, good idea. Can at least explore it now. There might be some performance issues using Proxies. |
I've experienced the same issue - solved it by introducing a cache: https://github.com/sindresorhus/pify/blob/proxy/index.js#L44 |
@schnittstabil Nice! Already looks very good. I commented some quick feedback on the commit, but haven't tried it out yet. When that's resolved, can you open a PR? Would make it easier to review. |
Yes but why? The code doesn't seem much/any shorter/simpler/faster than the regular version. |
@bfred-it Some things will just work compared to now, like ES6 classes, this binding, etc. |
Anyone wants to step in and finish #32? Including handle my review comments. I'll put a bounty on this shortly. I think it's better now to just have the proxy interface instead of both. Proxy is pretty optimized in newer Node.js versions. This task includes adding tests to handle all the things mentioned in the open issues too. |
@IssueHunt has funded $70.00 to this issue.
|
I'll take it. |
@sindresorhus has rewarded $63.00 to @frangio. See it on IssueHunt
|
ECMAScript6 Proxies are currently not available on node, therefore this issue is a reminder for future versions.
pify(obj)
should return an ECMAScript6 Proxy object, forwarding almost all operations toobj
, and promisifying only some functions, thus we almost surely get rid of most non-enumerable and inheritance issues.IssueHunt Summary
frangio has been rewarded.
Backers (Total: $70.00)
Submitted pull Requests
Tips
IssueHunt has been backed by the following sponsors. Become a sponsor
The text was updated successfully, but these errors were encountered: