New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TypeScript type definition #74
Comments
@issuehunt has funded $80.00 to this issue.
|
Working on this! |
For anyone wanting to work on this, see the initial attempt and feedback in #76. Note that this is not an easy task and requires you to have advanced TypeScript experience. There have been multiple attempts and a lot of wasted time on my part in the past. If you intend to work on this, please look at the previous attempts and the feedback given there. |
@omgimalexis has funded $20.00 to this issue.
|
This may help someone trying to fix this https://github.com/AlCalzone/DefinitelyTyped/blob/139c1679ecb5c2a475639582b7a312e4e7a1cde5/types/node/util.promisify.d.ts |
@sindresorhus I don't get it, is it still an issue? considering the existent type-definitions from https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/pify, I'm quite a bit confused 🤔 |
The best place for types is in the package itself. DefinitelyTyped is just a workaround until packages provide types themselves. Also, the types at DT are not very good. |
fair enough @sindresorhus |
indeed, those types seem incompleted! |
@renatobenks check the link I gave. That's from a commit to update the built in utils's promisify so it should a good reference to base these on. So far while using the ones I linked manually I've had no edge cases come up. |
Thank you for the suggestion @OmgImAlexis, I appreciate that! But unfortunately, I still didn't have a concise idea for moving forward from #76 |
@sindresorhus has rewarded $90.00 to @tom-sherman. See it on IssueHunt
|
Would be nice to have TypeScript type definitions bundled in this package. The types should be strict and should be generic so it preserves the original function type.
The type definition should follow this styleguide, and should have full docs and type tests.
Some examples:
Note that this is not an easy task and requires you to have advanced TypeScript experience. There have been multiple attempts and a lot of wasted time on my part in the past. If you intend to work on this, please look at the previous attempts and the feedback given there.
IssueHunt Summary
tom-sherman has been rewarded.
Backers (Total: $100.00)
Submitted pull Requests
Tips
The text was updated successfully, but these errors were encountered: