-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to be more in line with SRP #28
Comments
Sure, good idea, but I think the two open PRs should be merged first. Would you be able to help review #25? |
Absolutely! We can leave this one on hold until the other two PRs are merged. I'll take a look at 25 |
This can now be done if you're still interested @kolyaventuri :) |
I'll take a stab at it! |
@kolyaventuri Still interested? |
@sindresorhus hi! Yes, absolutely. Apologies on never getting back to this 😂 |
Bump :) |
Currently the package is defined in a single index.js file. Though it is a small package, it could be refactored to clean up the codebase and be more in line with single responsibility principles. For instance, there are some nested ternaries and an
add
method is defined within the function export.I would be willing to take this on and submit a PR, if that's alright!
The text was updated successfully, but these errors were encountered: