Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move .then/.catch-based modules to their own section #19

Closed
fregante opened this issue Jul 16, 2021 · 1 comment · Fixed by #20
Closed

Move .then/.catch-based modules to their own section #19

fregante opened this issue Jul 16, 2021 · 1 comment · Fixed by #20
Labels
help wanted

Comments

@fregante
Copy link
Contributor

fregante commented Jul 16, 2021 •
edited

Modules like p-log and p-tap don't fit the "avoid .then" suggestion, so they aren't as useful anymore.

What do you think about moving them to their own "old-style modules" section or something like that? With dozens of packages these IMHO are just clutter among packages are still useful.

They were even just updated for Node 12 support but their examples still have then/catch: https://github.com/sindresorhus/p-log
@sindresorhus
Copy link
Owner

I agree.

@Richienb Richienb mentioned this issue Jul 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reorganize with async/await in mind Richienb/promise-fun
2 participants
@sindresorhus @fregante