Create publicIp default export to return IPv6 (preference) or IPv4 (fallback)

[Octalbyte]

No description provided.

[Octalbyte]

Refers to #45

[Octalbyte]

Thise PR is technically concluded. However, I think I will add documentation for the new feature. Actually, I need to extend the changes to the browser version :/

[Octalbyte]

Sorry for all those "ava fix" commits.

[Octalbyte]

Now the PR is ready for merge.

[sindresorhus]

While I appreciate the pull request, this is still far from being mergable. I recommend you look over your own code and you also need to add tests and TypeScript type updates.

[sindresorhus]

#45 (comment)

[Octalbyte]

@sindresorhus I've deleted the line mytest.js in the gitignore. Additionally, I've restructured the publicIp() function to use the Promise.any API. It is much simpler and cleaner now. I also added browser tests.
I am only not sure about:

• How to add type definitions, now that publicIp is a function with other functions inside it
• Which tests should be added for publicIp on node? Should they only run when the environment variable CI is false?
• If an user has both IPv4 and IPv6, the IPv4 Promise might resolve sooner than the IPv6. And I found no safe way to make the thread sleep for some miliseconds, to give IPv6 an advantage.

[Octalbyte]

@Richienb I changed the PR according to requested. However, the re-request review button is not working for me.

[sindresorhus]

You also need to update the types, add docs, and add tests.

[sindresorhus]

I would recommend trying to figure out the questions you asked yourself.

[Richienb]

If an user has both IPv4 and IPv6, the IPv4 Promise might resolve sooner than the IPv6. And I found no safe way to make the thread sleep for some miliseconds, to give IPv6 an advantage.

If IPv6 resolves first, cancel IPv4 but if IPv4 resolves first, wait for IPv6.