Fix sorting existing query params in URL when sort option is false (#…

…265) Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
sindresorhus · Jun 11, 2020 · 549d677 · 549d677
1 parent d3da28b
commit 549d677
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -361,7 +361,7 @@ exports.stringifyUrl = (input, options) => {
 
 	const url = removeHash(input.url).split('?')[0] || '';
 	const queryFromUrl = exports.extract(input.url);
-	const parsedQueryFromUrl = exports.parse(queryFromUrl);
+	const parsedQueryFromUrl = exports.parse(queryFromUrl, {sort: false});
 
 	const query = Object.assign(parsedQueryFromUrl, input.query);
 	let queryString = exports.stringify(query, options);

diff --git a/test/stringify-url.js b/test/stringify-url.js
@@ -52,3 +52,7 @@ test('stringify URL from the result of `parseUrl` with query string that contain
 	const parsedUrl = queryString.parseUrl(url);
 	t.deepEqual(queryString.stringifyUrl(parsedUrl, {encode: false}), url);
 });
+
+test('stringify URL without sorting existing query params', t => {
+	t.deepEqual(queryString.stringifyUrl({url: 'https://foo.bar?C=3&A=1', query: {D: 4, B: 2}}, {sort: false}), 'https://foo.bar?C=3&A=1&D=4&B=2');
+});