Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support hash #220

Closed
projct1 opened this issue Nov 5, 2019 · 1 comment · Fixed by #222
Closed

Support hash #220

projct1 opened this issue Nov 5, 2019 · 1 comment · Fixed by #222
Labels
enhancement help wanted

Comments

@projct1
Copy link

projct1 commented Nov 5, 2019 •
edited 

queryString.parseUrl('https://www.omg.com/page#param1&param2');

Result without hash...

{​
    query: Object {  }
​    url: "https://www.omg.com/page"
}
@sindresorhus sindresorhus changed the title Cant parse hash? Support hash Nov 13, 2019
@sindresorhus
Copy link
Owner

That's not currently supported. This is about query strings after all. That being said, I'm willing to merge a high-quality PR adding support for this. (Needs to add tests, docs, index.d.ts update).

@Mark1626 Mark1626 mentioned this issue Nov 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for parsing/stringifying fragment identifier Mark1626/query-string
2 participants
@sindresorhus @projct1