Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting for..of loops for older Browsers #266

Closed
geoalexidis opened this issue Jun 19, 2020 · 1 comment
Closed

Adjusting for..of loops for older Browsers #266

geoalexidis opened this issue Jun 19, 2020 · 1 comment

Comments

@geoalexidis
Copy link

geoalexidis commented Jun 19, 2020

Hi guys,

I've seen that you have changed your forEach loops to for..of loops from version 5 to 6.

This breaks the usage in older browsers and even with my usage of the most up to date create-react-app this isn't getting transpiled properly.

Would you accept a pull request using forEach loops from me or what is actually the reason behind this change?

I'm using now version 5 but would like to keep up with the latest.

Thanks and best regards.

PS: There might be another reason why for..of aren't transpiled but I haven't dug too much in it.
See: https://daverupert.com/2017/10/for-of-loops-are-bad/

@sindresorhus
Copy link
Owner

This module targets Node.js 6 or later and the latest version of Chrome, Firefox, and Safari. If you want support for older browsers, or, if your project is using create-react-app v1, use version 5: npm install query-string@5.

I have no intention of changing anything to make it compatible with older browser, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants