Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning on Angular 10 #271

Closed
menaheme opened this issue Jul 19, 2020 · 1 comment
Closed

Warning on Angular 10 #271

menaheme opened this issue Jul 19, 2020 · 1 comment

Comments

@menaheme
Copy link

i am using query string to build GET requests in an Angular app.

Recently, after updating to Angular 10, i started getting build warnings,saying that using query string may hinder the package size, since its a commonjs dependecy.

Heres the warning from the angular blog
warning

And here`s the link to the article https://blog.angular.io/version-10-of-angular-now-available-78960babd41

@sindresorhus
Copy link
Owner

While it can be true in some cases (it's not in this case), adding a warning for all CommonJS packages is just total nonsense by the Angular team. Most packages on npm are CommonJS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants