Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't parse the question mark #311

Closed
afshin-hoseini opened this issue Apr 14, 2021 · 7 comments
Closed

Shouldn't parse the question mark #311

afshin-hoseini opened this issue Apr 14, 2021 · 7 comments

Comments

@afshin-hoseini
Copy link

afshin-hoseini commented Apr 14, 2021

Also as documented, the question mark at the start of string shouldn't be considered as a part of first parameter's name.

This snippet:

queryString.parse('?code=123')

results {'?code':'123'}

Here is also a screen shot from the console:

image

@sindresorhus
Copy link
Owner

t.deepEqual(queryString.parse('?foo=bar'), {foo: 'bar'});

You're probably using querystring instead of query-string.

@afshin-hoseini
Copy link
Author

afshin-hoseini commented Apr 15, 2021

@sindresorhus

🤦🏻‍♂️ I am resigning today 🥲

@cmaster11
Copy link

@sindresorhus

🤦🏻‍♂️ I am resigning today 🥲

I feel you

@BugKiller-tech
Copy link

I met the same issue today. I just imported 'querystring' instead of 'query-string'

@iKrushYou
Copy link

Ran into this issue today, thankfully I'm not the first :)

@debaraj-barua
Copy link

I am SMRT

So I am not the only smrt one

I basically copied the package from the very place I was instructed not to.

Screenshot 2021-08-30 at 13 27 22

@ackmanx
Copy link

ackmanx commented Sep 11, 2022

The frustrating part about this for me was that I actually installed query-string but apparently have querystring installed from another dependency so when Intellij auto-imported the latter I didn't notice 😮‍💨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants