Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipNull and skipEmptyString are not working as intended #313

Closed
closingin opened this issue May 13, 2021 · 2 comments
Closed

skipNull and skipEmptyString are not working as intended #313

closingin opened this issue May 13, 2021 · 2 comments

Comments

@closingin
Copy link

Hello there!

I've just installed query-string@^5.1.1 on my project, and both skipNull and skipEmptyString are not working as intended, they do not remove null/empty items from the returned string 馃

I checked against a sample from your documentation:

queryString.stringify({ a: 1, b: '', c: null, d: 4 }, {
    skipNull: true,
    skipEmptyString: true
})
// a=1&b=&c&d=4

Maybe a regression?

@sindresorhus
Copy link
Owner

You're not using the latest version of this package.

@closingin
Copy link
Author

Oh my. I'm so sorry, my npm installed this version by default, I don't know why. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants