-
-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
named imports under v8 #363
Comments
I don't intend to support this. I don't like named exports when the named imports have too generic names. |
Well, they have generic names but they are imported from |
In large files, the import can be far away from where it's actually used. A user could indeed rename, but it's not a good API design to force the user to rename to a better name themselves. |
Hi, I've been using this lib importing
stringify
andparse
by name,import { stringify, parse } from 'query-string'
under v7, but on v8 this is not possible anymore. Onv7
this worked thanks to static parsing of thecommonjs
module.I tried to add support for this to send a PR, but the linter doesn't like that there are both named exports and default exports with
stringify
andparse
properties, so this would mean a huge refactor.Was wondering if you intend to support this, or if this usage is deprecated?
Thanks!
The text was updated successfully, but these errors were encountered: