Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot be used in server side rendering #8

Closed
SamyPesse opened this issue Feb 5, 2018 · 3 comments · Fixed by #12
Closed

Cannot be used in server side rendering #8

SamyPesse opened this issue Feb 5, 2018 · 3 comments · Fixed by #12
Labels
enhancement New feature or request 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted Extra attention is needed

Comments

@SamyPesse
Copy link

SamyPesse commented Feb 5, 2018

Issuehunt badges

Because of createBrowserHistory which throw: Browser history needs a DOM.

One solution may be to return a memory router if the module is loaded in a non-dom environment.
(I'm not using this module for the history export but for the useful route components).


IssueHunt Summary

[
<
i
m
g

s
r
c

'
h
t
t
p
s
:
/
/
a
v
a
t
a
r
s
3
.
g
i
t
h
u
b
u
s
e
r
c
o
n
t
e
n
t
.
c
o
m
/
u
/
1
7
6
6
0
1
8
?
v

4
'

a
l
t

'
r
a
f
a
e
l
f
b
s
'

w
i
d
t
h

2
4

h
e
i
g
h
t

2
4

r
a
f
a
e
l
f
b
s
]
(
h
t
t
p
s
:
/
/
i
s
s
u
e
h
u
n
t
.
i
o
/
u
/
r
a
f
a
e
l
f
b
s
)

h
a
s

b
e
e
n

r
e
w
a
r
d
e
d
.

Backers (Total: $40.00)

Submitted pull Requests


Tips


IssueHunt has been backed by the following sponsors. Become a sponsor

@sindresorhus
Copy link
Owner

I've never done server-side rendering, but I'm happy to merge a PR with a fix.

@sindresorhus sindresorhus added enhancement New feature or request help wanted Extra attention is needed labels Feb 8, 2018
@IssueHuntBot
Copy link

@IssueHunt has funded $40.00 to this issue.


@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label May 10, 2019
@issuehunt-oss issuehunt-oss bot added 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt and removed 💵 Funded on Issuehunt This issue has been funded on Issuehunt labels Jun 19, 2019
@issuehunt-oss
Copy link

issuehunt-oss bot commented Jun 19, 2019

@sindresorhus has rewarded $36.00 to @rafaelfbs. See it on IssueHunt

  • 💰 Total deposit: $40.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $4.00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants