-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 8.0.0 doesn't work #17
Comments
Please read the release notes. |
Awesome! Thanks for your rapid answer |
While I love ESM syntax and I use ESM syntax via typescript, the new ESM only version has an untented consequence that all downstream libraries have to adapt ESM in order to use the lastest version. In my case, I can't use it with typescript anymore since my target is commonjs. We can still use v7 without the issue, but it'd better if v8 is released as a hybrid npm package with both commonjs & ESM. See How to Create a Hybrid NPM Module for ESM and CommonJS for example. |
Same issue as @alvis, this change forces all downstream modules to use ESM and makes typescript transpilation to commonjs impossible! Edit: Replaced read-pkg-up with https://sami-chkhachkhi.medium.com/import-version-from-package-json-ef47fe505d9d instead. |
The most recent version 8.0.0 is not working.
According to the error messages, following imports are malformed:
https://github.com/sindresorhus/read-pkg-up/blob/e6fbe7f1ce52cbfb924543ef0e9801775efc38cc/index.js#L1-L2
I'm facing following message:
The text was updated successfully, but these errors were encountered: