Avoid console error in add-releases-tab

Fixes #901
refined-github · May 25, 2018 · 7df0a1e · 7df0a1e
1 parent 622a92b
commit 7df0a1e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/source/features/add-releases-tab.js b/source/features/add-releases-tab.js
@@ -1,5 +1,5 @@
-import select from 'select-dom';
 import {h} from 'dom-chef';
+import select from 'select-dom';
 import * as icons from '../libs/icons';
 import * as pageDetect from '../libs/page-detect';
 import {registerShortcut} from './improve-shortcut-help';
@@ -20,9 +20,11 @@ function appendReleasesCount(count) {
 
 function updateReleasesCount() {
 	if (pageDetect.isRepoRoot()) {
-		const releasesCount = select('.numbers-summary a[href$="/releases"] .num').textContent.trim();
-		localCache = {[repoKey]: releasesCount};
-		browser.storage.local.set(localCache);
+		const releasesCount = select('.numbers-summary a[href$="/releases"] .num');
+		if (releasesCount) {
+			localCache = {[repoKey]: Number(releasesCount.textContent)};
+			browser.storage.local.set(localCache);
+		}
 	}
 }
 

diff --git a/test/page-detect.js b/test/page-detect.js
@@ -368,9 +368,12 @@ test('isRepoTree', urlMatcherMacro, pageDetect.isRepoTree, [
 	'https://github.com/sindresorhus/refined-github/tree/master/distribution',
 	'https://github.com/sindresorhus/refined-github/tree/0.13.0/distribution',
 	'https://github.com/sindresorhus/refined-github/tree/57bf435ee12d14b482df0bbd88013a2814c7512e/distribution',
-	'https://github.com/sindresorhus/refined-github/tree/57bf4'
+	'https://github.com/sindresorhus/refined-github/tree/57bf4',
+	'https://github.com/sindresorhus/refined-github?files=1',
+	'https://github.com/sindresorhus/refined-github/tree/master?files=1'
 ], [
 	'https://github.com/sindresorhus/refined-github/issues',
+	'https://github.com/sindresorhus/refined-github/issues?files=1',
 	'https://github.com/sindresorhus/refined-github/blob/tree/master/distribution'
 ]);