Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

J + K navigation for scrolling down / up when reviewing a PR #1070

Closed
vanniktech opened this issue Feb 6, 2018 · 7 comments
Closed

J + K navigation for scrolling down / up when reviewing a PR #1070

vanniktech opened this issue Feb 6, 2018 · 7 comments

Comments

@vanniktech
Copy link
Contributor

Vim like shortcuts for scrolling in a PR by using j for scrolling down and k for scrolling up would be super beneficial.

@fregante
Copy link
Member

fregante commented Feb 6, 2018

j/k are previous/next item... in this case what items are we navigating?

@vanniktech
Copy link
Contributor Author

Basically scrolling up and down as you'd do with the arrow keys.

@fregante
Copy link
Member

fregante commented Feb 6, 2018

Why not use the arrow keys?

@vanniktech
Copy link
Contributor Author

Further away plus if you use the other - to come - shortcuts you would not need to move your hands. Especially if you're used to typing blindly in the 10 finger system.

@fregante
Copy link
Member

fregante commented Feb 8, 2018

Nah, if you want to scroll with j/k you can likely set that up to be global rather than just on GitHub

@fregante fregante closed this as completed Feb 8, 2018
@vanniktech
Copy link
Contributor Author

Just for the record. This chrome plugin works really well for this.

@hkdobrev
Copy link
Contributor

hkdobrev commented Mar 6, 2018

I'd still like navigating to next/prev file with j/k similar to navigating issues/PRs and other lists on GitHub. That with a shortcut for collapsing files would make reviews of long PRs quite easier with the keyboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants