Don't clutter the global search bar in the global Pull Requests page

[nacimgoura]

Hello, I think I encountered a bug. When I click on the "pull request" button on the navbar, the filters get into both input of the page instead of just being in the filter input.

bfred-it earned $40.00 by resolving this issue!

• Checkout the Issuehunt explorer to discover more funded issues.
• Need some help from other developers? Add your repositories on Issuehunt to raise funds.

[lukaszklis]

Seems to be caused by https://github.com/sindresorhus/refined-github/blob/7f23ff66be7a3f713fd5f06977b36427130c49d5/source/features/sort-issues-by-update-time.js#L29-L30, I believe it should be fixed by limiting the scope of the selectors to target repository-related ”Pull requests” and ”Issues” links.

[fregante]

I think that’s a consequence of the update time sorting. Not much it can be done about it

[yakov116]

@bfred-it can we clear the field after loading the page?

[fregante]

That would disable the sorting on the searches

[yakov116]

@bfred-it I thought the sorting was for when we load the page. When I search not always is it needed to be by last updated.

Can we make an x or a clear field button?

[fregante]

The sorting ideally should be consistent across the site, truly a new default.

We could however fixing this issue in two ways:

• clearing out the header search, because that’s global, duplicate and-who-cares 👈
• clearing the fields BUT applying the sorting when the search form is submitted. This would be nice because the sorting would be applied invisibly. However we can’t clear out the fields randomly because the user might have typed something in. RGH would have to understand which queries by the user and leave them untouched.

[IssueHuntBot]

@IssueHunt has funded $40.00 to this issue.

---

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

[janat08]

I did this by narrowing down selectors to links. the sorting still works.

[IssueHuntBot]

@sindresorhus has rewarded $36.00 to @bfred-it. See it on IssueHunt

• 💰 Total deposit: $40.00
• 🎉 Repository reward(0%): $0.00
• 🔧 Service fee(10%): $4.00

[janat08]

So the thing is that my solution actually worked, instead of applying bandaid on it. Obviously, the reason why some random text gets applied to input with selector for href is not because the selector is bad (since href doesn't exist on input you see), but because you must clear the input after the fact and get a bounty out of it in lieu of first solution.

[fregante]

So the thing is that my solution actually worked

I'm not sure of where you get that from, I tried and it didn't — because it changed nothing. The feature your PR modified, does not affect the input field directly, in fact you can disable RGH and:

1. Visit /pulls
2. Type "hello" in the right-side search field
3. Press Enter
4. You'll see "Hello" in the global search bar, the same "issue"

This is because GitHub applies the q parameter to both fields on the page, even if they point to two different search results.

The reason why our feature (the one you modified) makes the query appear in the global search field (while the regular "Created" and "Assigned" tabs don't) is that we effectively modify the query (and GitHub doesn't hide it from the global field like it does for its own tabs)

[janat08]

right, I didn't read issue description to begin with.