Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native GitHub hovercards on reaction avatars #1286

Closed
j-f1 opened this issue Apr 25, 2018 · 4 comments
Closed

Use native GitHub hovercards on reaction avatars #1286

j-f1 opened this issue Apr 25, 2018 · 4 comments

Comments

@j-f1
Copy link

j-f1 commented Apr 25, 2018

Currently, the avatars displayed next to reactions use GitHub’s old-style hovercard with just the user’s name:

screenshot 2018-04-25 at 9 41 12 am

However, avatars on GitHub now use this hovercard:

screenshot 2018-04-25 at 9 49 56 am

Would it be possible to use this hovercard on reactions?

@hkdobrev
Copy link
Contributor

This could work for 1 person, but we need to show a list of people who reacted.

@j-f1
Copy link
Author

j-f1 commented Apr 25, 2018

Why not show the hovercard for each person only when hovering over their avatar?

@fregante
Copy link
Member

I’d go the opposite way actually because Firefox does not support hover on elements inside the buttons. This led to us restoring the single tooltip with all the names and now it looks like that with two tooltips.

Do you know if there’s a way to see a list of all the people who reacted? Not that any of this is particularly useful information anyway…

@sindresorhus
Copy link
Member

Going to pass on this. The avatars are just meant to give an quick indication whether there are people you know that voted, not as a means of discovering new people. I would recommend submitting a feature request to GitHub instead to improve showing the people that voted natively: support@github.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants